Conversation
|
Size Change: +102 B (0%) Total Size: 824 kB
ℹ️ View Unchanged
|
6 tasks
4d0f540 to
5af1538
Compare
Member
Author
|
Thanks! In order to add the shortcut, we'll need this: #22224 |
Member
|
The button continues to say "Copied!" until you select a different block. That seems like a bug to me. Also, I think the "copied" message should use a snackbar notification instead of modifying the button text (which is bad for accessibility). But anyway, this is a nice feature to have. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small quality of life improvement for touchscreen users or users who don't use keyboard shortcuts. This PR adds a button to the collapsed block actions (next to duplicate etc.) to copy the selected block(s). Quite similar to the "Copy all blocks", but then for the selected block.
I think it could be useful to add the shortcut in the block menu, but I'm planning to refactor ClipboardButton first because that component cannot be used for any button component. So I'll add it in a follow up, but I think this by itself is already useful.
How has this been tested?
Screenshots
Types of changes
Checklist: