Block Directory: Remove the author rating when none exist#22184
Merged
Block Directory: Remove the author rating when none exist#22184
Conversation
A `0` rating means there have been no reviews submitted, so we can omit this string.
|
Size Change: +13 B (0%) Total Size: 824 kB
ℹ️ View Unchanged
|
Contributor
|
If the author only has 1 block, the average rating should match the rating on the block. I wonder if it provides any value in that scenario as well. |
Contributor
Author
|
🤔 It's repetitive, but it doesn't look negative like a 0 rating does. I think we can leave it, and maybe #22149 will do something about that. |
StevenDufresne
approved these changes
May 12, 2020
Contributor
StevenDufresne
left a comment
There was a problem hiding this comment.
Fine by me! Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A
0rating means there have been no reviews submitted, but currently it looks like a negative rating. This removes the rating part of the string in that case.See #17440 & comment
How to test
whateverstreamshareScreenshots
No reviews:
With reviews:
