Fix props in example code for Edit Post module#21976
Merged
gziolo merged 2 commits intoWordPress:masterfrom Apr 30, 2020
Merged
Fix props in example code for Edit Post module#21976gziolo merged 2 commits intoWordPress:masterfrom
gziolo merged 2 commits intoWordPress:masterfrom
Conversation
gziolo
requested changes
Apr 30, 2020
Member
gziolo
left a comment
There was a problem hiding this comment.
Travis fails and I discovered what’s the reason. The same change needs to be applied to JSDoc comment of the documented component. So it’s autogenerated from source code with npm run docs:build command.
Contributor
Author
|
@gziolo updated the JSDoc too. I hope this time Travis won't fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the props in example code for Edit Post module's PluginBlockSettingsMenuItem API
How has this been tested?
I made a custom component that uses this example code snippet with my fixes.
Types of changes
Fixed with proper JSX syntax that we use to write props value
Checklist: