Write block patterns in PHP to allow i18n#21946
Merged
youknowriad merged 1 commit intomasterfrom Apr 28, 2020
Merged
Conversation
|
Size Change: 0 B Total Size: 816 kB ℹ️ View Unchanged
|
mtias
reviewed
Apr 28, 2020
lib/client-assets.php
Outdated
Member
There was a problem hiding this comment.
Do we need to keep support for both for a bit?
Contributor
Author
There was a problem hiding this comment.
No we don't, since this was a function that only loaded the fixed set of patterns in Gutenberg and all of these have been migrated. There's no possibility this was used by third-party users.
62570c8 to
0967255
Compare
mtias
approved these changes
Apr 28, 2020
|
Hi, guys. Sorry for offtop, but I've found this post with my search request: |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved from JSON to regular php files and made the patterns title translatable.
It's possible to add translations to the content as well as shown in the example here (Cover ABC) but I preferred to keep this separate from this PR.