Size Change: +298 B (0%)

Total Size: 825 kB

_{compressed-size-action}

This is working really well, Riad!
I have a couple of comments:

1. Labels

I know that this is following the proposal from #21080, but because patterns don't have a label, I don't know what to search for in the first place. I'd love to hear what you think @mapk and @mtias. I think labels are important for many reasons, search being one of them.

2. Global search

Because the search box is above the 'Blocks' and 'Patterns' tabs, I expected searching to be global among those two categories. See #21080 (comment) for an example. Is this something we can try?

This is looking good, nice work, good small iterative improvements as we learn what is necessary and what isn't.

I'm seeing a horizontal scrollbar:

If I apply overflow: hidden; to .block-editor-inserter__panel-content, it's gone, but the hover outline is still cropped weirdly:

Digging a little deeper, if I remove width: 100% here, everything is beautiful — before:

.block-editor-block-preview__container {
    position: relative;
    width: 100%;
    overflow: hidden;
}

after:

.block-editor-block-preview__container {
    position: relative;
    overflow: hidden;
}

And you get this:

@jasmussen this suggest change looks good but noting that I don't have the issue myself. It also seems the suggestions breaks the block previews for the style variations.

I think labels are important for many reasons, search being one of them.

Yes, at least they should show up when you search. We still need to work through the categories for patterns.

I restored the labels for patterns and I explored global search on this branch https://github.com/WordPress/gutenberg/tree/try/global-search

the global search is a bigger change than I originally thought for the inserter code. Let me know how it feels and if you think we should merge it here or move forward with the separate search as v1.

Let's do separate search to get it merged while we still refine the design.

Hi Riad, was trying to compile try/global-search, but got this:

Did you forget to commit a file? I did do npm install first.

@jasmussen sorry a small mistake of mine, I force pushed (fixed)

Ok, so for me this is ready to land as a V1

Keyboard insertion is fixed, it was broken in master too.

Curious has this been done? I just created a few custom block patterns using register_block_pattern and added keywords to the patterns, but if I'm in the Gutenberg editor and type a forward slash on a new line, I only see blocks (no patterns). Seems like this should also search for patterns (which I believe is what the OP was getting at). Anyways, thanks for you hard work! Cheers.

@bradley2083 The search has only been implemented on the main inserter (not the slash inserter). having it on the slash inserter is a great idea though, would you mind opening an issue for it?

@youknowriad Done.

Thank you