[Mobile] Wrap button blocks with buttons blocks in page templates#21939
Merged
[Mobile] Wrap button blocks with buttons blocks in page templates#21939
Conversation
Merged
2 tasks
|
Size Change: -19.3 kB (2%) Total Size: 816 kB
ℹ️ View Unchanged
|
geriux
approved these changes
Apr 28, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Tested both on iOS and Android ✅ Thanks for updating the templates!
Contributor
Author
|
Thanks Gerardo for testing! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2190Description
This PR wraps the unwrapped Button blocks in page templates with Buttons blocks. This commit will be cherry-picked to the release branch for the
1.27.0release to address this issue.How has this been tested?
Steps:
Prerequisite: Test via a self-hosted site
Expect:
The button should not be outside the flow of the page.
Screenshots
Types of changes
Non-breaking change which fixes an issue
Checklist: