Reinitialize the iframe after the parent block is moved around#21916
Merged
Reinitialize the iframe after the parent block is moved around#21916
Conversation
This was referenced Apr 27, 2020
|
Size Change: -705 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
draganescu
approved these changes
Apr 28, 2020
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Code looks good and problem is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As reported in #6146, YouTube block becomes blank when the block is moved down (reordered). The root cause of this issue is the fact that browsers tend to reload the iframe if it's moved around in the DOM Tree, and the fact that React does not correctly dispatch the onLoad event in that case (see facebook/react#18752).
This PR changes the way we register the iframe sandbox initialization callback from
onLoad=toiframe.addEventListener. This skips the React event dispatching machinery and keeps the code running.Before:
After:
Fixes #6146
How has this been tested?
Tested locally
Types of changes
Non-breaking changes
Checklist: