Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package#21780
Merged
ockham merged 6 commits intoApr 22, 2020
Conversation
No idea why this one even had to be added in the first place.
|
Size Change: 0 B Total Size: 842 kB ℹ️ View Unchanged
|
talldan
approved these changes
Apr 22, 2020
talldan
left a comment
Contributor
There was a problem hiding this comment.
If the tests pass I see no reason not to merge 👍
Thanks for following up on this!
…kage As per packages/README.md
6 tasks
Contributor
|
Thanks @Soean for updating the |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes x2 problems that have broken e2e tests:
1. Unwanted deprecation notice assertions
Now that #21721 has landed the deprecation notice for
useApiFetchwithin the Navigation Block no longer fires for that block (because it no longer uses the hook!).Therefore we no longer need to add assertions in our e2e tests to
expectthe console to warning about this deprecation. This PR removes those assertions from the e2e tests.gutenberg/packages/e2e-tests/specs/experiments/navigation.test.js
Lines 166 to 168 in 8acbb4f
and
gutenberg/packages/e2e-tests/specs/experiments/multi-entity-saving.test.js
Lines 176 to 178 in 8acbb4f
2. Incorrectly installed dependency of @wordpress/api-fetch
Previously the
@wordpress/deprecateddependency was directly installed into@wordpress/api-fetchwithout usinglerna. This has been corrected.How has this been tested?
On Master branch
useApiFetchdeprecation notice aboveOn this PR's branch
useApiFetchhookTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: