Skip to content

Cover block - enable upload options in production#21776

Merged
mkevins merged 44 commits intomasterfrom
rnmobile/feature/cover-block-enable-upload-options-in-production
Apr 24, 2020
Merged

Cover block - enable upload options in production#21776
mkevins merged 44 commits intomasterfrom
rnmobile/feature/cover-block-enable-upload-options-in-production

Conversation

@mkevins
Copy link
Copy Markdown
Contributor

@mkevins mkevins commented Apr 22, 2020 •
edited
Loading

Description

This PR enables upload options for Cover block in production.

Related PR

Testing steps

Builds

Android iOS
APK IPA
  1. Install the peril build
  2. Add a cover block to a post
  3. Tap "Add Image or Video"

Expected:

Media upload options should be available in the bottom sheet.

Screenshots

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Gerardo Pacheco and others added 30 commits March 18, 2020 16:46
RNMobile - Enable Cover for Production
db947e4
RNMobile - Cover block - Move gradient background to support overlay …
daac549 
…functionality
RNMobile - Cover - Image With Focal Point - Check for url changes
9319533
Merge branch 'master' of github.com:WordPress/gutenberg into rnmobile…
9597f49 
…/enable-cover
Merge branch 'master' into rnmobile/enable-cover
0afffdb
@mkevins
Enable upload options for cover block behind dev flag
c9ff047
@mkevins
Use [].prototype.some for media-library-only prop
6e3988a
@mkevins
Use destructuring in renderBackground function
3d1b254
@mkevins
Add progress indicator for uploading media
43ae0a5
@mkevins
Use default import syntax for Video component
e51d95b
@mkevins
Use optional chaining
5cd723e
@mkevins
Add z-index to upload progress bar
7f00459
Merge branch 'master' into rnmobile/enable-cover
9605e11 
# Conflicts:
#	packages/block-library/src/cover/edit.native.js
@mkevins
Make renderContent prop optional in MediaUploadProgress
ec46565
@mkevins
Initialize some state variables for failure ui
7946e92
@mkevins
Add cancel and retry behaviors when media tapped
315feca
@mkevins
Bind state machine variables to media upload progress
8627812
@mkevins
Render failed state view when upload fails
df808e4
@mkevins
WIP - add temporary dashicon hack to pass stroke color
2231329
@mkevins
Merge branch 'rnmobile/enable-cover' into rnmobile/feature/cover-bloc…
b101674 
…k-uploads-dev-only
@mkevins
Merge branch 'rnmobile/feature/cover-block-uploads-dev-only' into rnm…
b5b1cbf 
…obile/feature/cover-block-uploads-progress
@mkevins
Merge branch 'rnmobile/feature/cover-block-uploads-progress' into rnm…
fd1c0c7 
…obile/feature/cover-block-uploads-failure-ui
@mkevins
Merge branch 'master' into rnmobile/feature/cover-block-uploads-dev-only
6964525
@mkevins
Merge branch 'rnmobile/feature/cover-block-uploads-dev-only' into rnm…
1b62e3c 
…obile/feature/cover-block-uploads-progress
@mkevins
Merge branch 'rnmobile/feature/cover-block-uploads-progress' into rnm…
22aac05 
…obile/feature/cover-block-uploads-failure-ui
@mkevins
Fix lint
82b0880
@mkevins
Merge branch 'rnmobile/feature/cover-block-uploads-progress' into rnm…
becb870 
…obile/feature/cover-block-uploads-failure-ui
@mkevins
Fix lint
bd982e8
@mkevins
Merge branch 'master' into rnmobile/feature/cover-block-uploads-failu…
cf7c423 
…re-ui
@mkevins
Revert "WIP - add temporary dashicon hack to pass stroke color"
a9c7cb8 
This reverts commit 2231329.
mkevins added 12 commits April 10, 2020 20:43
@mkevins
Use background-color with border-radius for upload failure icon
83a5d38
@mkevins
Fix lint
d7c8c3f
@mkevins
Add z-index for media upload progress
db53b6a
@mkevins
Merge branch 'master' into rnmobile/feature/cover-block-uploads-failu…
7ce6024 
…re-ui
@mkevins
Use color studio colors for cover block upload failure icon
024ac5b
@mkevins
Enable Cover block upload options in production
c67c07a
@mkevins
Add error icon for cover block upload failure
ee7a28f
@mkevins
Revert "Add error icon for cover block upload failure"
03a09ff 
This reverts commit 74b978e07e7a98fcf09110935c6e779eb808f2aa.
@mkevins
Use $red-40 for cover error icon in dark and light mode
078940f
@mkevins
Merge branch 'master' into rnmobile/feature/cover-block-uploads-failu…
de76c57 
…re-ui
@mkevins
Merge branch 'rnmobile/feature/cover-block-uploads-failure-ui' into r…
6442c25 
…nmobile/feature/cover-block-enable-upload-options-in-production
@mkevins
Merge branch 'master' into rnmobile/feature/cover-block-enable-upload…
d8bfa3b 
…-options-in-production
@mkevins mkevins added [Feature] Media Anything that impacts the experience of managing media Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Apr 22, 2020
@mkevins mkevins mentioned this pull request Apr 22, 2020
Merged
2 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 22, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 845 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.08 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.24 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 761 B 0 B
build/block-editor/index.js 105 kB 0 B
build/block-editor/style-rtl.css 10.1 kB 0 B
build/block-editor/style.css 10.1 kB 0 B
build/block-library/editor-rtl.css 7.13 kB 0 B
build/block-library/editor.css 7.13 kB 0 B
build/block-library/index.js 112 kB 0 B
build/block-library/style-rtl.css 7.19 kB 0 B
build/block-library/style.css 7.19 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 198 kB 0 B
build/components/style-rtl.css 16.9 kB 0 B
build/components/style.css 16.9 kB 0 B
build/compose/index.js 6.66 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 3.54 kB 0 B
build/edit-navigation/style-rtl.css 485 B 0 B
build/edit-navigation/style.css 485 B 0 B
build/edit-post/index.js 28.2 kB 0 B
build/edit-post/style-rtl.css 12.5 kB 0 B
build/edit-post/style.css 12.5 kB 0 B
build/edit-site/index.js 10.8 kB 0 B
build/edit-site/style-rtl.css 5.25 kB 0 B
build/edit-site/style.css 5.24 kB 0 B
build/edit-widgets/index.js 8.33 kB 0 B
build/edit-widgets/style-rtl.css 5 kB 0 B
build/edit-widgets/style.css 5 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/editor/index.js 43.4 kB 0 B
build/editor/style-rtl.css 3.27 kB 0 B
build/editor/style.css 3.27 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.32 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.67 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.67 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

This was referenced Apr 22, 2020
Closed
Closed
@mkevins mkevins requested a review from geriux April 23, 2020 05:16
geriux
geriux approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested media uploads on both iOS and Android ✅ :shipit:

Nice work!!

@mkevins mkevins merged commit 50f1bd5 into master Apr 24, 2020
@mkevins mkevins deleted the rnmobile/feature/cover-block-enable-upload-options-in-production branch April 24, 2020 08:54
@github-actions github-actions bot added this to the Gutenberg 8.0 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Media Anything that impacts the experience of managing media Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

Gutenberg 8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mkevins @geriux