Size Change: -1.01 MB (87%) 🏆

Total Size: 1.15 MB

_{compressed-size-action}

I've added a snackbar notice for removing menu items. The problem I am facing is that while in #21486 I was able to curtail the cache of the entity store by creating local state out of the inital get menus call, here the edit menu component is remounted and the menu items are taken from the cache again.

As a quick fix we could not use entities :) or otherwise we need the delete option in place. In absence, the delete works but on switching between menus the cache wrongly shows deleted menu items too.

cc @noisysocks

@draganescu I think I got it to work, the culprit was the invalidateCache: true sent with the REMOVE_ITEMS action

This is looking really good!

We need to add unit tests for the two new actions (removeItems and deleteEntityRecord) as well as the new branch (REMOVE_ITEMS) in the reducer.

Let's also add a note to @wordpress/core-data's CHANGELOG.md.

@draganescu I rebased, tested a few scenarios, and here's what happened:

Apparently nested items break the deletions and it appears to be a bug in the hook because all the nested items get deleted.