Rnmobile/fix font size breakage#21527
Merged
SergioEstevao merged 2 commits intomasterfrom Apr 10, 2020
Merged
Conversation
This allow that font size attributes are still read and saved properly in mobile.
2 tasks
|
Size Change: -7 B (0%) Total Size: 903 kB
ℹ️ View Unchanged
|
Contributor
|
👋 Sérgio! Looking at the diff it seems that the Platform selection is removed and the code is unified with the web, making this feel like there is typography support on native mobile too, but the PR description mentions |
youknowriad
approved these changes
Apr 10, 2020
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
Makes sense to move the check up in the tree
Contributor
Author
|
@hypest if you look at the diff in the |
hypest
reviewed
Apr 10, 2020
Contributor
Ah, sorry for not noticing that. This makes sense now, the check got expanded to include both font-size and line-height, thanks for updating the PR description with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix font size breakage that was created because mobile Gutenberg doesn't yet support editing of typography attributes.
The breakage can be seen by selecting a paragraph control and then tapping on the settings icon (cog).
Before the typography settings consisted only on the line size, but now they were expanded to have font size, and joined together in a single Panel called Typography.
This PR hides the full typography panel in RN GB-mobile instead of just the line-size attribute.
How has this been tested?
This can be tested using this PR in GB-mobile: wordpress-mobile/gutenberg-mobile#2149
Screenshots
Types of changes
Checklist: