Update 'Welcome Guide' illustrations#21515
Merged
enriquesanchez merged 2 commits intomasterfrom Apr 13, 2020
Merged
Conversation
|
Size Change: -65.8 kB (7%) ✅ Total Size: 838 kB
ℹ️ View Unchanged
|
Member
|
Great iteration. One point which maybe is a hint at needing to change UI would be this:
The dots to navigate being the same background color is a little strange for me. It then seems like the background should interact. |
mapk
approved these changes
Apr 10, 2020
Contributor
mapk
left a comment
There was a problem hiding this comment.
Looks pretty good to me and worked well.
I'm not sure if we have a pattern of dots elsewhere that we can pull from. If there are some quick changes that can be made to those, go for it. Otherwise, this works!
Member
|
I would also love to try the gifs from #19209 (defaulting to the static images if prefers-reduced-motion is set). |
mtias
approved these changes
Apr 10, 2020
Contributor
Author
|
Merging these updated illustrations. I'll look at moving forward the proposal from #19209 on separate PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21396
This PR updates the illustrations used in the Welcome Guide modal to match the new editor's styles (G2).
Before
New
It also updates the little inline inserter icon in the description of "Get to know the block library":