Allow reusable block top and bottom paddings to collapse.#21472
Merged
Allow reusable block top and bottom paddings to collapse.#21472
Conversation
|
Size Change: +6 B (0%) Total Size: 903 kB
ℹ️ View Unchanged
|
MichaelArestad
approved these changes
Apr 9, 2020
Contributor
MichaelArestad
left a comment
There was a problem hiding this comment.
Works for me. Tested with several of the core blocks and some complicated stuff like nested columns.
Contributor
Author
|
Thanks. I'll rebase and merge when I have a chance, it's little code and easy to revert. |
This is a followup and addition to #21312. It's separate because it's not a regression.
cdebbd8 to
5b92d6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup and addition to #21312. It's separate because it's not a regression.
The code here (props @MichaelArestad ) allows the margins of the first and last blocks inside a reusable block container to collapse. The end is that reusable blocks do not suddenly get double top and bottom margins, which they do currently. Before:
After:
Note that this PR is an enhancement and not a regression fix. It also needs slightly more testing to verify the display property doesn't break an aspect of reusable blocks.
The horizontal padding you see in the above screenshots is fixed in #21312, which is a regression.