Skip to content

fix/[#21440] Copy/cut input values copying entire block#21457

Merged
youknowriad merged 1 commit intoWordPress:masterfrom
kirilzh:fix/copying-entire-blocks
Apr 8, 2020
Merged

fix/[#21440] Copy/cut input values copying entire block#21457
youknowriad merged 1 commit intoWordPress:masterfrom
kirilzh:fix/copying-entire-blocks

Conversation

@kirilzh
Copy link
Copy Markdown
Contributor

@kirilzh kirilzh commented Apr 7, 2020

Description

In block-editor/src/components/copy-handler/index.js this check does not pass

// Let native copy behaviour take over in input fields.
if ( ! hasMultiSelection() && documentHasSelection() ) {
	return;
}

because documentHasSelection() returns false. Going deeper we see there’s a check if a text fields has a selection

function documentHasSelection() {
	if ( isTextField( document.activeElement ) ) {
		return true;
	}

	const selection = window.getSelection();
	const range = selection.rangeCount ? selection.getRangeAt( 0 ) : null;

	return range && ! range.collapsed;
}

I then stumbled upon this. Hence I added a function checking only <input type="number" />.

How has this been tested?

In both Chrome and FF on MacOS.

Types of changes

Bug fix (non-breaking change) which fixes #21440 .

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@kirilzh kirilzh requested a review from ellatrix as a code owner April 7, 2020 13:45
youknowriad
youknowriad reviewed Apr 8, 2020
View reviewed changes
packages/dom/src/dom.js
return true;
}

if ( isNumberInput( document.activeElement ) ) {
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this inside isTextField or should it be a separate function? Or more precisely, do we consider a "number" input as a text field? I might think yes but curious what others think?

Copy link
Copy Markdown
Contributor Author

@kirilzh kirilzh Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I extended isTextField but later I asked myself the same question and to me it makes more sense to have them separated. I don't consider numbers as text per se. Also curious what others think : )

youknowriad
youknowriad reviewed Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, I'll do some testing

youknowriad
youknowriad approved these changes Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work very well :) Thanks for the fix.

@youknowriad youknowriad merged commit a3a06e5 into WordPress:master Apr 8, 2020
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Paste labels Apr 8, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 8, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2020

Congratulations on your first merged pull request, @kirilzh! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Apr 8, 2020
@tomusborne
Copy link
Copy Markdown

tomusborne commented Apr 15, 2020

This has fixed the copying part of the issue, but I'm still seeing an issue once the value is pasted back into the field. The pasted value replaces the block itself, instead of being added to the field.

@kirilzh kirilzh mentioned this pull request Apr 23, 2020
Closed
@mcsf mcsf mentioned this pull request Apr 18, 2022
Merged
@ntsekouras ntsekouras mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

No one assigned

Labels

[Feature] Paste First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 7.9

Development

Successfully merging this pull request may close these issues.

Copy/cut input values copying entire block/removing block

3 participants

@kirilzh @tomusborne @youknowriad