Fix ServerSideRender link point to 404 page#21409
Closed
widoz wants to merge 4 commits intoWordPress:wp/5.4from
widoz:patch-2
Closed
Fix ServerSideRender link point to 404 page#21409widoz wants to merge 4 commits intoWordPress:wp/5.4from widoz:patch-2
ServerSideRender link point to 404 page#21409widoz wants to merge 4 commits intoWordPress:wp/5.4from
widoz:patch-2
Conversation
The component page `ServerSideRender` seems no longer exists infact, looking at pages with [ServerSideRender](https://developer.wordpress.org/block-editor/?s=ServerSideRender) a possible user will get two results, the dynamic page which is the current one and the packages page which contains the documentation for the server side render package. Therefore I suppose a papable page could be https://developer.wordpress.org/block-editor/packages/packages-server-side-render/
Found the right path for the documentation page
mkaz
approved these changes
Apr 13, 2020
Member
mkaz
left a comment
There was a problem hiding this comment.
👍 Looks good, thanks for the fix
Member
|
Thanks for this fix, it looks like it was opened against the WordPress 5.4 branch. |
Member
|
@widoz It looks like you don't need to close and create a new one. You should be able to edit this PR and switch the branch it is against to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component page
ServerSideRenderseems no longer exists infact, looking at pages with ServerSideRender a possible user will get two results, the dynamic page which is the current one and the packages page which contains the documentation for the server side render package.Therefore I suppose a papable page could be https://developer.wordpress.org/block-editor/packages/packages-server-side-render/