Refactor env commands into separate files#21353
Merged
noahtallen merged 2 commits intomasterfrom Apr 10, 2020
Merged
Conversation
|
Size Change: 0 B Total Size: 884 kB ℹ️ View Unchanged
|
gziolo
approved these changes
Apr 10, 2020
Member
gziolo
left a comment
There was a problem hiding this comment.
The main thing I'm not sure about is the helper functions. For the most part, I made new files for them, and grouped all of the wordpress-related ones into wordpress.js.
I had the same thought before reading it 😃
Anyway, we can iterate further and this PR improves nicely code organization. I assumed that code works based on Travis 😅
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tries refactoring the env commands into separate files.
env.jswas getting quite large, so I wanted to space everything out a bit before adding a new command or logs. The main thing I'm not sure about is the helper functions. For the most part, I made new files for them, and grouped all of the wordpress-related ones intowordpress.js.cc @noisysocks for thoughts
How has this been tested?
Types of changes
Refactor