Skip to content

[RNMobile] remove additional padding from first paragraph block#21323

Merged
jbinda merged 1 commit intomasterfrom
rnmobile/fix/first-paragraph-block-alignment
Apr 2, 2020
Merged

[RNMobile] remove additional padding from first paragraph block#21323
jbinda merged 1 commit intomasterfrom
rnmobile/fix/first-paragraph-block-alignment

Conversation

@jbinda
Copy link
Copy Markdown
Contributor

@jbinda jbinda commented Apr 1, 2020 •
edited
Loading

Description

PR brings fix to avoid extra space in first Paragraph block after open new post.
I have also noticed that additional 3px margin is not necessary in Post Title and remove it as well

Please also refer to:
Related gutenberg-mobile PR
Related gutenberg-mobile issue

To Reproduce
Steps to reproduce the behaviour:

  1. Start a brand new post
  2. See the empty paragraph block placeholder text has too much padding.

Expected behaviour:
The placeholder text should be aligned to the same 16px key line as other blocks.

How has this been tested?

  1. Create new post
  2. See if additional space do not appear on first Paragraph block

Screenshots

BEFORE / AFTER:

Types of changes

Bug fix:

  • remove extra padding from first Paragraph block after open new post
  • remove additional padding from post title

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@jbinda jbinda added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Apr 1, 2020
@jbinda jbinda requested review from dratwas and pinarol April 1, 2020 13:38
@jbinda jbinda self-assigned this Apr 1, 2020
@jbinda jbinda mentioned this pull request Apr 1, 2020
Merged
2 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2020

Size Change: 0 B

Total Size: 883 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.45 kB 0 B
build/api-fetch/index.js 3.8 kB 0 B
build/autop/index.js 2.59 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.2 kB 0 B
build/block-library/editor-rtl.css 7.21 kB 0 B
build/block-library/editor.css 7.21 kB 0 B
build/block-library/index.js 110 kB 0 B
build/block-library/style-rtl.css 7.5 kB 0 B
build/block-library/style.css 7.51 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 16.1 kB 0 B
build/components/style.css 16 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.7 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.23 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.05 kB 0 B
build/edit-navigation/index.js 2.4 kB 0 B
build/edit-navigation/style-rtl.css 95 B 0 B
build/edit-navigation/style.css 95 B 0 B
build/edit-post/index.js 92.3 kB 0 B
build/edit-post/style-rtl.css 12 kB 0 B
build/edit-post/style.css 12 kB 0 B
build/edit-site/index.js 9.04 kB 0 B
build/edit-site/style-rtl.css 4.62 kB 0 B
build/edit-site/style.css 4.61 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 3.74 kB 0 B
build/edit-widgets/style.css 3.74 kB 0 B
build/editor/editor-styles-rtl.css 423 B 0 B
build/editor/editor-styles.css 426 B 0 B
build/editor/index.js 42.8 kB 0 B
build/editor/style-rtl.css 3.47 kB 0 B
build/editor/style.css 3.47 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.94 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.7 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.5 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.6 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@jbinda jbinda merged commit 8e4d714 into master Apr 2, 2020
@jbinda jbinda deleted the rnmobile/fix/first-paragraph-block-alignment branch April 2, 2020 07:30
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dratwas dratwas dratwas approved these changes

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@jbinda jbinda

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

Gutenberg 7.9

Development

Successfully merging this pull request may close these issues.

2 participants

@jbinda @dratwas