[RNMobile] Unsupported fallback spike#21150
Merged
Conversation
|
Size Change: +23 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
19d279e to
7fe7a4b
Compare
9c79ee7 to
3e42365
Compare
guarani
reviewed
May 22, 2020
| onClose={ this.toggleSheet.bind( this ) } | ||
| onClose={ this.toggleSheet } | ||
| onModalHide={ () => { | ||
| if ( this.state.sendFallbackMessage ) { |
Contributor
There was a problem hiding this comment.
I'm sure you're already aware of this, but it would be great to have a way of passing information to onModalHide about which action caused the modal to close, without resorting to a boolean sendFallbackMessage property on the component.
When dismissing a modal on iOS we have an animation completion handler, but I don't see an equivalent pattern available with react-native-modal.
Contributor
There was a problem hiding this comment.
Looking into this with @etoledom we didn't find a better solution for now.
marecar3
approved these changes
Jun 5, 2020
Contributor
marecar3
left a comment
There was a problem hiding this comment.
LGTM!
We can merge it when build gets 🟢
26 tasks
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the UI to open an unsupported block on a web view.
gutenberg-mobileside PR: wordpress-mobile/gutenberg-mobile#2063