Merged
Conversation
|
Size Change: 0 B Total Size: 859 kB ℹ️ View Unchanged
|
mtias
approved these changes
Mar 25, 2020
Member
|
Let's get this one in @enriquesanchez :) |
Member
|
This one should have some line-height adjustments for when it breaks into two lines:
|
Member
|
@enriquesanchez also why is there an empty column on the left set to zero value?
|
Member
|
We should also really not do this :) A spacer would be better.
|
Contributor
Author
|
@mtias oh, I totally forgot about that hidden "space" :) I was messing with and trying different ways of aligning things. I'll open a new PR to fix that and adjust the line-height. As for the empty column, it was recommended to me as a hack to to have the text expand full width. If I were to use a paragraph block, its width would be very narrow and limiting. |
Member
Huh? Why would it be narrow? |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a block pattern for #20345.