Update the columns block to use the new colors hook#21038
Merged
youknowriad merged 4 commits intomasterfrom Mar 25, 2020
Merged
Update the columns block to use the new colors hook#21038youknowriad merged 4 commits intomasterfrom
youknowriad merged 4 commits intomasterfrom
Conversation
|
Size Change: -42 B (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
gziolo
reviewed
Mar 21, 2020
Member
gziolo
left a comment
There was a problem hiding this comment.
Nice, I like the direction.
Unrelated note. The number of experimental props used for RichText and InnerBlocks makes it nearly impossible for 3rd party devs to follow code implementation uses in Gutenberg 🙁 It also means it’s all undocumented and difficult to use for contributors...
Contributor
Author
True, we need to continue our audits. the color hook is something I want to stabilize pretty quickly |
92ef4bb to
dfca58c
Compare
0127313 to
5a2e929
Compare
Contributor
Author
|
This one is ready to ship. |
Contributor
Author
|
Oh, it seems we might need a deprecated version here, I'll add it and ship. |
07af0d0 to
5fed61c
Compare
youknowriad
commented
Mar 25, 2020
| // focus event, don't unnecessary transition to an inner tabbable. | ||
| if ( wrapper.current.contains( document.activeElement ) ) { | ||
| if ( | ||
| isInsideRootBlock( wrapper.current, document.activeElement ) |
Contributor
Author
There was a problem hiding this comment.
For me this is a bug that is present on master too. If you want to select a block, you want to select the root block, not an inner one.
youknowriad
commented
Mar 25, 2020
| await pressKeyWithModifier( 'ctrl', '`' ); | ||
| await pressKeyWithModifier( 'ctrl', '`' ); | ||
| await pressKeyTimes( 'Tab', 4 ); | ||
| await pressKeyTimes( 'Tab', 5 ); |
Contributor
Author
There was a problem hiding this comment.
The colors panel is shown before the columns count now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #21021 to try test the API on different blocks (columns for this PR)