Add basic nav block example for inserter and styles previews#21011
Merged
draganescu merged 1 commit intomasterfrom Mar 19, 2020
Merged
Add basic nav block example for inserter and styles previews#21011draganescu merged 1 commit intomasterfrom
draganescu merged 1 commit intomasterfrom
Conversation
|
Size Change: +58 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 19, 2020
Contributor
There was a problem hiding this comment.
The code looks good.
While testing I noticed three things which should make separate issues:
a) when the style selector open upward it has scrollbars
b) when styles show in FF I got scrollbars
c) even if the styles are called light and dark the preview does not show any difference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19872.
Adds an example for the nav block, which ensures the placeholder for the block doesn't show up in the styles preview.
How has this been tested?
Manual testing:
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: