Skip to content

Paste: replace iframes with url#20983

Merged
ellatrix merged 1 commit intomasterfrom
try/paste-iframe-to-text
Mar 19, 2020
Merged

Paste: replace iframes with url#20983
ellatrix merged 1 commit intomasterfrom
try/paste-iframe-to-text

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented Mar 18, 2020 •
edited
Loading

Description

Replaces #19998 and #19086. See #19086 (comment):

I've been thinking a bit more about this...

  • We're talking about changing the behaviour on (external) paste, which is probably a scenario where we should be careful with iframes.
  • The current way of handling iframe is not super useful. It's cool that it works when you have unfiltered HTML capabilities, in which case it will be put in the "advanced" HTML block. In other words, pasting iframes only works for some people, it wouldn't be a proper block, and pasting iframes generally from outside Gutenberg is a bit questionable.

I therefore propose to always convert iframes to a plain URL from its source attribute.

  • Blocks can add transforms matching this URL, just like the embed block does.
  • Paste no longer has to depend on user capabilities.

I'll follow up with a new PR.

How has this been tested?

For example, go to YouTube, click on "Share" and then "embed" and copy paste the iframe HTML. Now it will actually be converted to an embed block instead of HTML block.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2020

Size Change: -194 B (0%)

Total Size: 857 kB

Filename Size Change
build/block-editor/index.js 100 kB -48 B (0%)
build/block-library/index.js 111 kB -122 B (0%)
build/blocks/index.js 57.5 kB -24 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.23 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.2 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.2 kB 0 B
build/edit-post/style-rtl.css 8.52 kB 0 B
build/edit-post/style.css 8.51 kB 0 B
build/edit-site/index.js 5.07 kB 0 B
build/edit-site/style-rtl.css 2.53 kB 0 B
build/edit-site/style.css 2.53 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 44 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.09 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.58 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

mcsf
mcsf approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the approach and the PR looks good!

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Mar 19, 2020

Thanks @mcsf!

@ellatrix ellatrix merged commit f90dc20 into master Mar 19, 2020
@ellatrix ellatrix deleted the try/paste-iframe-to-text branch March 19, 2020 09:10
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 19, 2020
This was referenced Mar 19, 2020
Closed
Closed
Closed
@pento
Copy link
Copy Markdown
Member

pento commented Mar 23, 2020

This looks good, thanks for tackling it, @ellatrix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcsf mcsf mcsf approved these changes

@pento pento Awaiting requested review from pento

@aduth aduth Awaiting requested review from aduth

@glendaviesnz glendaviesnz Awaiting requested review from glendaviesnz

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@etoledom etoledom Awaiting requested review from etoledom

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

[Feature] Paste

Projects

None yet

Milestone

Gutenberg 7.8

Development

Successfully merging this pull request may close these issues.

3 participants

@ellatrix @pento @mcsf