Autocomplete: Add support for results with long titles#20962
Merged
youknowriad merged 1 commit intomasterfrom Mar 19, 2020
Merged
Autocomplete: Add support for results with long titles#20962youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
|
Size Change: +18 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
pento
approved these changes
Mar 19, 2020
Member
pento
left a comment
There was a problem hiding this comment.
This looks good to me.
The bug appears to be a regression caused by #19344, so I'd like an extra check from @youknowriad to confirm that this fix works within the broader G2 restructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Autocompletecomponent displays aPopoverconsisting of a list ofButtons, one for each autocomplete results.If the result title is multiple lines long, the
Buttonlabel gets centered.If the title is 3 or more lines long, the label gets cut off, as the
Buttonforces a36px($button-size) height.This PR makes sure that the
Buttons insideAutocompletehave automatic height, and their labels are left-aligned.How has this been tested?
Tested on Chrome 80 on Mac, running Gutenberg on the Jetpack Docker environment, at any possible screen size.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: