Conversation
This was referenced Mar 17, 2020
|
Size Change: +33 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
SergioEstevao
approved these changes
Mar 26, 2020
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Great work on this!
Member
Author
|
@jorgefilipecosta Can you take a look at the code as well please? |
jorgefilipecosta
approved these changes
Apr 7, 2020
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Things worked well in my tests. Nice work @ceyhun 👍
| className={ blockquoteClasses } | ||
| > | ||
| <RichText | ||
| identifier="value" |
Member
There was a problem hiding this comment.
Identifier and textAlign are only used by native code right?
Member
Author
There was a problem hiding this comment.
True for textAlign. But identifier also exists in web: https://github.com/WordPress/gutenberg/blob/master/packages/block-editor/src/components/rich-text/index.js#L118
| import { PanelBody, UnsupportedFooterControl } from '@wordpress/components'; | ||
| import { __ } from '@wordpress/i18n'; | ||
|
|
||
| const PanelColorSettings = () => { |
Member
There was a problem hiding this comment.
PanelColorSettings just uses PanelColorGradientSettings, it may be a good idea to add this code to PanelColorGradientSettings so we cover all use cases of colors and gradients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Pullquote block in React Native mobile Gutenberg.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#1920
Some previous discussions are in this closed PR which was from a fork and closed in favor of this one.
Known issues:
text-transform: uppercase) doesn't workWanted to get an initial feedback for this so I've put this block under dev flag for now. Planning to handle these issues in a follow-up PR.
How has this been tested?
Pullquoteblock from inserter menuScreenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: