Update page template picker after design review#20883
Merged
Conversation
2 tasks
|
Size Change: +238 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
geriux
approved these changes
Mar 16, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the improvements and for the new hook 👏 Tested on both iOS and Android.
| const preferredColorScheme = usePreferredColorScheme(); | ||
| const containerBackgroundColor = | ||
| preferredColorScheme === 'dark' ? 'black' : 'white'; | ||
| const previewContainerStyle = usePreferredColorSchemeStyle( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some of the items in wordpress-mobile/gutenberg-mobile#2012
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2020
This PR adjusts the modal header bar and adds some padding to the template preview so it aligns with where the editor content would start if it had a title:
It also introduces a new
usePreferredColorSchemeStylehook to make dark mode support a bit nicer in functional components.Checklist: