Skip to content

[RNMobile] Add useResizeObserver() to Column Block#20838

Merged
jbinda merged 19 commits intornmobile/column-blockfrom
rnmobile/column-block-with-container-matches-hoc
Mar 16, 2020
Merged

[RNMobile] Add useResizeObserver() to Column Block#20838
jbinda merged 19 commits intornmobile/column-blockfrom
rnmobile/column-block-with-container-matches-hoc

Conversation

@jbinda
Copy link
Copy Markdown
Contributor

@jbinda jbinda commented Mar 12, 2020 •
edited
Loading

Description

This PR brings adjustments need to allow using useResizeObserver() inside Column Block.

Please refer to:
useResizeObserver() PR
Column Block PR

How has this been tested?

Checking all Column Block PR testing requirements (see Column PR description)

Types of changes

New feature - Change the way how container size is measured.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

lukewalczak and others added 18 commits January 27, 2020 20:44
@lukewalczak
Create withContainerMatches HOC
c60d675
@lukewalczak
Replace HOC in favor of hook
50bbadc
@lukewalczak
Add useContainerMatch hook tests
74d9227
@lukewalczak
Merge branch 'master' into rnmobile/with-container-matches-hoc
64f894a
@lukewalczak
Merge branch 'master' into rnmobile/with-container-matches-hoc
8c22c00
@lukewalczak
Refactor hook to be useResizeObserver() and unify with web API
aa3eeaa
@lukewalczak
Remove old implementation and update tests
a741278
@lukewalczak
Avoid setting state in onLayout frequently
057990d
@lukewalczak
Add comment and improve typing
6f48b92
@lukewalczak
Move observer to const to avoid adding comment for disabling eslint
2ac3218
@lukewalczak
Refactor doc
0b3ac33
@jbinda
Merge remote-tracking branch 'origin/rnmobile/with-container-matches-…
f87111f 
…hoc' into rnmobile/try/column-block-with-useResizeObserver
@jbinda
use resizeObserver in COlumns
423ac9c
@lukewalczak
Refactor doc and web light wrapper
8b02d17
@jbinda
Merge remote-tracking branch 'origin/rnmobile/with-container-matches-…
441457b 
…hoc' into rnmobile/try/column-block-with-useResizeObserver
@jbinda
Merge branch 'rnmobile/column-block' into rnmobile/try/column-block-w…
369d0c8 
…ith-useResizeObserver
@jbinda
Merge branch 'rnmobile/column-block' into rnmobile/column-block-with-…
43a9fdc 
…container-matches-hoc
@jbinda
Merge branch 'rnmobile/column-block' into rnmobile/column-block-with-…
ac53446 
…container-matches-hoc
@jbinda jbinda added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Columns Affects the Columns Block labels Mar 12, 2020
@jbinda jbinda self-assigned this Mar 12, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 856 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.03 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 100 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.23 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/index.js 111 kB 0 B
build/block-library/style-rtl.css 7.38 kB 0 B
build/block-library/style.css 7.39 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 6.22 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.21 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.3 kB 0 B
build/edit-post/style-rtl.css 8.64 kB 0 B
build/edit-post/style.css 8.64 kB 0 B
build/edit-site/index.js 4.64 kB 0 B
build/edit-site/style-rtl.css 2.48 kB 0 B
build/edit-site/style.css 2.48 kB 0 B
build/edit-widgets/index.js 4.45 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.09 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 779 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@jbinda jbinda mentioned this pull request Mar 13, 2020
Merged
6 tasks
@jbinda jbinda marked this pull request as ready for review March 13, 2020 14:59
@jbinda jbinda requested review from lukewalczak and pinarol March 16, 2020 06:50
@jbinda jbinda merged commit 8118b95 into rnmobile/column-block Mar 16, 2020
@jbinda jbinda deleted the rnmobile/column-block-with-container-matches-hoc branch March 16, 2020 10:01
@jbinda jbinda mentioned this pull request Apr 8, 2020
Open
@adamziel adamziel mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukewalczak lukewalczak lukewalczak approved these changes

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@jbinda jbinda

Labels

[Block] Columns Affects the Columns Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbinda @lukewalczak