Styles Panel: Don't force it to be closed by default.#20617
Merged
Conversation
|
Size Change: -1 B Total Size: 865 kB
ℹ️ View Unchanged
|
Contributor
|
This looks good. I do wonder if we should make it an option. We could combine with #20620, and provide a few different options for styles... |
Contributor
|
I agree with @scruffian in that it would be nice to have a set of options for the styles panel. Also, changing the current behaviour for existing blocks might be confusing. |
Member
Author
|
I'm wary of making a configurable option for something this small, particularly given that I don't think the current behaviour was intended. |
Contributor
|
@jasmussen @mapk thoughts |
Contributor
|
Just to clarify:
If yes to both of these, I'd say ship it as it seems an obvious improvement. |
youknowriad
approved these changes
Mar 16, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#6038 originally hid the Advanced panel by default, which I agree is the correct behaviour. In #10543, which turned the Advanced panel into the Styles panel, this behaviour was retained.
Whilst working on Automattic/jetpack#14852, I found the inability to set the
initialOpenvalue of the Styles panel to be a little frustrating, but on further investigation, I'm inclined to think that #10543 incorrectly retained this behaviour from the Advanced panel, and it should be changed.How has this been tested?
Tested against Automattic/jetpack#14852.
It can also be tested against Core blocks that provide styles: for example, the Quote block.
Checklist: