[RNMobile] Fix crash pasting HTML with wrapped images.#20499
Merged
Conversation
2 tasks
|
Size Change: +5 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
SergioEstevao
approved these changes
Mar 11, 2020
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Thanks for this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1950
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#1964Description
Adding a check for
node.classListto avoid a crash pasting HTML containing wrapped image figures.The PR that broke this behaviour on Mobile is #19064
On mobile, since
classListis undefined, we won't be able to have this choice, so we can only inline all figures or extract them all. I opted for the later, since the inline image experience on Paragraph block is rather poor on mobile. The Image block will offer a much richer experience.cc @ellatrix @iamthomasbishop
To test: