Skip to content

[RNMobile] Correct add icon appearance#20241

Merged
lukewalczak merged 2 commits intomasterfrom
rnmobile/correct-add-icon
Feb 14, 2020
Merged

[RNMobile] Correct add icon appearance#20241
lukewalczak merged 2 commits intomasterfrom
rnmobile/correct-add-icon

Conversation

@lukewalczak
Copy link
Copy Markdown
Member

@lukewalczak lukewalczak commented Feb 14, 2020

Description

Like in the title I've corrected inserter icon appearance

Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1918

How has this been tested?

  1. Open the app
  2. Observe add icon

Screenshots

before after
Screenshot 2020-02-14 at 17 22 32 Screenshot 2020-02-14 at 17 19 16

Types of changes

Remove redundant styles related to old dashicon.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak self-assigned this Feb 14, 2020
@lukewalczak lukewalczak added the [Type] Bug An existing feature does not function as intended label Feb 14, 2020
Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove border-color: $blue-30; in .addBlockButtonDark as well

Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukewalczak lukewalczak merged commit 0609348 into master Feb 14, 2020
@lukewalczak lukewalczak deleted the rnmobile/correct-add-icon branch February 14, 2020 17:21
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants