Unblock Button block for production#20093
Merged
lukewalczak merged 10 commits intomasterfrom Feb 14, 2020
Merged
Conversation
2 tasks
geriux
approved these changes
Feb 10, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Tested from the WordPress Android build -> wordpress-mobile/gutenberg-mobile#1866 (comment)
dratwas
reviewed
Feb 13, 2020
Member
|
Did another test after the latest changes and all is working great! LGTM! |
Contributor
|
LGTM! Good job @lukewalczak |
dratwas
approved these changes
Feb 14, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unblocking Button block for production
ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1866
How has this been tested?
https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/button.md
Screenshots
Types of changes
Checklist: