NavigationLink: set width in order to show caret#20075
Merged
Conversation
This was referenced Feb 6, 2020
jeryj
approved these changes
Feb 6, 2020
Contributor
jeryj
left a comment
There was a problem hiding this comment.
Looks good! Works as expected and I couldn't get it to break :)
Contributor
Author
Keep trying!!! |
marekhrabe
approved these changes
Feb 6, 2020
Contributor
marekhrabe
left a comment
There was a problem hiding this comment.
Same, works well!
The 20px seems random but considering how the arrow is made (border-width based triangle), I think we are fine using the absolute number here
Contributor
|
I tried a few different numbers in there to see the effect, and |
Contributor
Author
|
Thanks for the feedback. We could add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a min-width to the label of the Navigation Link when it's empty, and also focused, in order to show the carte.
Fixes the #20073
How has this been tested?
before
6) The caret is hidden
after
7) The caret should be shown.
Screenshots
Types of changes
Checklist: