Add format-js to scripts README for Prettier support#19766
Closed
Add format-js to scripts README for Prettier support#19766
Conversation
ntwb
reviewed
Jan 20, 2020
ntwb
reviewed
Jan 20, 2020
ntwb
reviewed
Jan 20, 2020
ntwb
requested changes
Jan 20, 2020
Member
ntwb
left a comment
There was a problem hiding this comment.
Looks good, just need to update the instances of format-js to format:js in line with the lint:* nomenclature.
There are already a couple of instances where format:js was used to
Co-Authored-By: Stephen Edgar <stephen@netweb.com.au>
ntwb
reviewed
Jan 21, 2020
Member
Author
|
Closing in favor of #19946 |
Member
|
I see I reviewed it and missed when working on my patch 😞 The good part is that the version I pushed looks similar :) |
1 task
Member
Author
|
I've done similar, so no worries. There's so much happening hard to keep track of every PR. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the scripts README with
format-jsinstructions for Prettier support.This should either be cherry picked into #18048 or merged after.
Types of changes
Documentation, confirm it works as expected.