Block Editor: Link Control: Use URL as link when title empty#19739
Merged
Block Editor: Link Control: Use URL as link when title empty#19739
Conversation
This was referenced Jan 17, 2020
youknowriad
approved these changes
Jan 20, 2020
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍
We may also land the "submit button" as well. It's weird that you can't resubmit the link when you edit it.
Member
Author
Yeah, I see this heavily tied to #19651 in that the behavior of the empty title was the main blocker remaining there. We should be able to merge the other after this. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #19735
Unblocks #19651 (#19651 (comment))
Cherry-picks from #19462 (see remarks)
This pull request seeks to improve the display of
<LinkControl />when a title is not set for the value by using the URL as the rendered external link when the title is unset.Testing Instructions:
In the Buttons and/or Navigation Link blocks, verify that when editing a link, the rendered result shows the title, if assigned, or otherwise the display-formatted URL: