Fix Navigation Link url escaping#19679
Merged
noahtallen merged 3 commits intoWordPress:masterfrom Jan 15, 2020
Merged
Conversation
Member
|
Can we use native A good related issue about it: https://stackoverflow.com/questions/75980/when-are-you-supposed-to-use-escape-instead-of-encodeuri-encodeuricomponent |
Contributor
Author
Definitely! Thanks for linking that issue that is great to know. I have updated it to now use With encodeURI function |
Member
|
I'll go ahead and merge this for you since everything is looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #19632 .
This PR updates the navigation-link component to pass the url through the
escapefunction on saving a new link. Previously, a link such as http://example.com/?s=<> would lead to http://example.com/?s= when used on the front-end. Now, links saved with the url passed through the escape function will lead to the expected href on the front end.How has this been tested?
Tested on local docker environment using links saved on the Navigation block.
Screenshots
In the editor
Saved without escape function
Saved with escape function
On the Front-End
Saved without escape function
Saved with escape function
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: