Skip to content

Fix focus capture#19621

Merged
gziolo merged 1 commit intomasterfrom
try/fix-focus-capture
Jan 14, 2020
Merged

Fix focus capture#19621
gziolo merged 1 commit intomasterfrom
try/fix-focus-capture

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented Jan 14, 2020

Description

Tries to fix #19591.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix requested a review from jasmussen January 14, 2020 11:31
@ellatrix ellatrix mentioned this pull request Jan 14, 2020
Closed
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Jan 14, 2020
@jasmussen
Copy link
Copy Markdown
Contributor

jasmussen commented Jan 14, 2020

That does fix it, yes!

focus

What was the issue?

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Jan 14, 2020

Looks like you're not allowed to delete the current property of a reference created by useRef. I'm not sure why I wasn't getting the error though. Maybe I don't have React loading in dev mode.

jasmussen
jasmussen approved these changes Jan 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a small fix, and one that fixes an issue for me. If you need a better code review feel free, otherwise, ship it!

@gziolo gziolo merged commit 8f7d582 into master Jan 14, 2020
@gziolo gziolo deleted the try/fix-focus-capture branch January 14, 2020 12:46
@gziolo gziolo added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jan 14, 2020
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasmussen jasmussen jasmussen approved these changes

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 7.3

Development

Successfully merging this pull request may close these issues.

Focus is lost when tabbing from toolbar back to block.

3 participants

@ellatrix @jasmussen @gziolo