Media & Text: Remove "Insert from URL" from the replacement flow.#19606
Merged
draganescu merged 1 commit intomasterfrom Jan 14, 2020
Merged
Media & Text: Remove "Insert from URL" from the replacement flow.#19606draganescu merged 1 commit intomasterfrom
draganescu merged 1 commit intomasterfrom
Conversation
draganescu
approved these changes
Jan 14, 2020
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Yes, this works great @Soean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the "Insert from URL" from the
MediaReplaceFlowin the Media & Text block, because this Block doesn't support this feature yet. If we add an URL, we can't detect if it's an image or a video. If we first add a video and then replace it with an image, it breaks.We already have #14397 to add this feature the block.
Placeholder:
Replacement
Before
After
@draganescu