Block: reposition tabbable inserter#19596
Merged
Conversation
This was referenced Jan 13, 2020
Member
Author
|
Chatted with @MarcoZehe and we agreed that it makes sense for the inserter to be positioned before the block toolbar (in tab order) as this makes it more clearer that it's not a block control. if this is not good, we can always change the tab position but keep the visual position. |
6 tasks
This was referenced Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unblocks #19322.
This PR moves the tabbable inserter before the block toolbar.
In the future we can polish this by perhaps centring the button and add one below the block as well.
Why before the toolbar? Because technically you don't leave the block until you exit the block toolbar, and the inserter buttons make most sense on the edges of the block, before and after the block.
The following button normally invisible. It's only visible on focus.
How has this been tested?
Screenshots
Types of changes
Checklist: