Adds media replace flow to the cover block#19583
Merged
draganescu merged 2 commits intomasterfrom Jan 14, 2020
Merged
Conversation
Soean
requested changes
Jan 11, 2020
mtias
reviewed
Jan 13, 2020
| <MediaReplaceFlow | ||
| mediaURL={ url } | ||
| allowedTypes={ ALLOWED_MEDIA_TYPES } | ||
| accept="image/*,video/*" |
Member
There was a problem hiding this comment.
Why does this need to be specified twice given ALLOWED_MEDIA_TYPES already says the same?
Contributor
Author
There was a problem hiding this comment.
Yes that is a very good question :) and the reason why one of them always ends up wrong
Soean
approved these changes
Jan 13, 2020
Member
Soean
left a comment
There was a problem hiding this comment.
Code looks good and replacement works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the new media replace control to the toolbar of the cover block.
How has this been tested?
Tested locally.
Screenshots
Types of changes
Non breaking enhancement.