Add type and angle picking to the custom gradient component#19582
Conversation
0ce5e5f to
e41c723
Compare
|
This PR was rebased and now includes the angle picker by default. It is ready for a review. |
|
I'm excited to get this in! Here's some feedback that might help tighten this up a bit more.
These changes should look something like this: |
|
One more minor text change here that could help. Accordion title = This may help avoid repetition in the text. |
e41c723 to
a90e781
Compare
a90e781 to
8827cd5
Compare
draganescu
left a comment
There was a problem hiding this comment.
Tested and works perfectly. Codewise everything looks good.
|
@mapk Hallo!! I'm helping out @jorgefilipecosta with the design follow ups :) Will create a separate PR with updates! |
|
@mapk Haii! I had a question 👋
If we do this, then there's no indication of which gradient type is active: How would you like to proceed? |
The grey border in that image should be removed. But the grey background on the icon when it's selected should remain. I hope that helps! |




Description
This PR adds a UI to pick choose between linear and radial gradients and a UI to pick an angle on linear gradients.
The UI is based on some of the designs suggested in #16662.
The changes seem huge but the file custom-gradient-bar.js is purely a rename from index.js with some class name changes plugs a logic to support radial gradient in the bar. I made the rename in a separate commit but GitHub continues to show all the file as new :(
The file index.js is new (while GitHub shows lots of removals from the old file.
How has this been tested?
I verified I can choose between radial and linear gradients.
I verified for linear gradients I can choose an angle for the gradient.
Screenshots