RNMobile: Consolidate logic hiding blocks from release builds to one location#19516
Merged
RNMobile: Consolidate logic hiding blocks from release builds to one location#19516
Conversation
2 tasks
etoledom
approved these changes
Jan 13, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks great and works perfectly 🎉
Tested on iOS dev and production mode.
Nice job @mchowning !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related gutenberg-mobile PR
Summary
The purpose of this PR is to address a bit of technical debt by consolidating our handling of restricting blocks to dev mode to a single location. Before this PR we registered the code block in all builds and later unregistered it if it was a release build, whereas the gallery block was never registered in release builds. This made it necessary to check two different locations to see whether a block was enabled for release builds. Now we take the same approach with both blocks and never register them if it is a release build.
How has this been tested?
Verify that code and gallery blocks appear in development builds, but not in release builds.
Checklist: