Block Editor: Remove (more) legacy "editor-" class name compatibility#19489
Merged
Block Editor: Remove (more) legacy "editor-" class name compatibility#19489
Conversation
youknowriad
approved these changes
Jan 9, 2020
6 tasks
This was referenced Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #19050
This pull request seeks to remove more instances of
editor--prefixed legacy className compatibility.These fall under one of two reasons for not having been included as part of #19050:
block-editor, or not consistent with the containing directory name).Implementation Notes:
In the case of
block-editor-block-settings-menu__control, the use was quite widespread, and it turned out that there are no styles or tests which reference this class name. For this reason, it was simply removed altogether.Testing Instructions:
Verify there are no regressions in affected components (block options menu items, link editing form).