Conversation
aduth
reviewed
Jan 2, 2020
| id={ blockElementId } | ||
| ref={ wrapper } | ||
| onMouseOver={ maybeHover } | ||
| onMouseOverHandled={ hideHoverEffects } |
Member
There was a problem hiding this comment.
I think this was the only usage of the "Handled" behavior for IgnoreNestedEvents, so it could be removed. Not sure that it will make a ton of difference, but at least simplifying a bit.
Effectively would amount to a revert of 0d0c8e0d55849529227df3540ad35ff3edf5be5b (from #5658)
Member
Author
|
I think this is a sensible change. If you create a new (empty) paragraph, it is selected, and you'll see the side inserter. If you select another block, the side inserter is gone. It makes sense to select the block again to see the side inserter. Additionally, there's the in-between inserters which are consistently available for every block on hover. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removed the
is-hoveredclass on blocks when hovering over them. The styles had been removed in #18862.It also removes the hover state in the block, which is only used for one thing: showing the side block inserter when the default block is empty. I would suggest to either:
I chose the first option, but I don't mind changing it.
-- @jasmussen
It's also worth noting that this removes a number of event handlers that are added to every single block.
Also reverts 0d0c8e0 (from #5658) because this is no longer needed.
How has this been tested?
Screenshots
Types of changes
Checklist: