Data: Invalidate store subscription on change in isAsync#19205
Closed
Data: Invalidate store subscription on change in isAsync#19205
Conversation
12 tasks
youknowriad
approved these changes
Dec 18, 2019
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
LGTM.
I haven't tested but the unit test is explicit enough.
This was referenced Dec 18, 2019
epiqueras
requested changes
Dec 20, 2019
| const registry = useRegistry(); | ||
| const isAsync = useAsyncMode(); | ||
| const queueContext = useMemo( () => ( { queue: true } ), [ registry ] ); | ||
| const queueContext = useMemo( () => ( { queue: true } ), [ registry, isAsync ] ); |
Contributor
There was a problem hiding this comment.
This will make us lose previous callbacks when async mode changes.
Also see #19199 (comment).
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19199
Unblocks: #19007
This pull request seeks to update the behavior of
useSelectto rerun selectors when the value of theisAsynccontext changes. Without these changes, there can be cases such as that described in #19199 where an updated selector value will not take effect when the context value changes.It's unclear to me whether there might be a related issue with the implementation of the priority queue where flushes should be expected to force the
onStoreChangecallback (see #13056 (comment)).Testing Instructions:
Repeat steps to reproduce from #19199, verifying that each implementation of the block renders as expected.
Ensure unit tests pass: