Skip to content

Block API: Pasting content that results in a new block shouldn't be treated as inline content.#19084

Merged
ellatrix merged 4 commits intomasterfrom
fix/18390-pasting-single-lines
Dec 21, 2019
Merged

Block API: Pasting content that results in a new block shouldn't be treated as inline content.#19084
ellatrix merged 4 commits intomasterfrom
fix/18390-pasting-single-lines

Conversation

@pento
Copy link
Copy Markdown
Member

@pento pento commented Dec 12, 2019 •
edited
Loading

Description

When pasting text, the paste handler currently assumes that if the text doesn't have a line break, and it results in one block, it can be treated as inline text, instead.

This may be correct for core, but is not necessarily correct for plugins that may wish to transform a single line of text into a custom block.

This PR tightens the paste handler assumption to only allow a selection of blocks to be treated as an inline paste.

Fixes #18390.

How has this been tested?

Tested with the sample plugin in #18390.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@pento pento added [Type] Bug An existing feature does not function as intended [Feature] Paste labels Dec 12, 2019
@pento pento self-assigned this Dec 12, 2019
@pento pento mentioned this pull request Dec 12, 2019
Closed
6 tasks
ellatrix
ellatrix reviewed Dec 12, 2019
View reviewed changes
@ellatrix
Copy link
Copy Markdown
Member

ellatrix commented Dec 12, 2019

Could some sort of test be added?

@pento
Copy link
Copy Markdown
Member Author

pento commented Dec 13, 2019

The new supports.pasteTextInline property defaults to false, so blocks will need to opt-in to being overridden when pasting inline text.

I've added some tests, too.

@ellatrix
Copy link
Copy Markdown
Member

ellatrix commented Dec 21, 2019

@pento I marked pasteTextInline as an unstable API as I'm not expecting any non core blocks to use this feature (as you have noted yourself). Let's see if there are more cases popping up.

ellatrix
ellatrix approved these changes Dec 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this makes sense! :)

@ellatrix ellatrix merged commit 03928a5 into master Dec 21, 2019
@ellatrix ellatrix deleted the fix/18390-pasting-single-lines branch December 21, 2019 18:28
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellatrix ellatrix ellatrix approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@mkaz mkaz Awaiting requested review from mkaz

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@pento pento

Labels

[Feature] Paste [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 7.2

Development

Successfully merging this pull request may close these issues.

Block API: pasteHandler() incorrectly treats single-line pastes as inline content.

3 participants

@pento @ellatrix @youknowriad