Add a type=submit to the search suggestion buttons#18933
Conversation
|
When I click on a search result in the navigation block search suggestions, I see a console warning:
I have also observed that this can cause end-to-end test failures: I expect that since this button is also assigned an |
|
@aduth Yep, I noticed that too and this bug when working on #18929. I've made a separate issue for it (#19056) and plan to pick it up once I work on a few of my PRs. The root cause of this is a bit further in the past—previously these suggestions were using A fix could involve suggestions being handled by |
Description
Recently pressing enter to submit a url as a navigation link in the nav block stopped working. It looks like the
LinkControlSearchItempreviously relied on being atype="submit"button. It was recently changed to use theButtoncomponent, which has a defaulttype="button". This PR changes it back to asubmitbutton to restore the functionality.How has this been tested?
e2e tests are being worked on in #18929, which is how this was discovered.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: