Fix padding regression with appender#18865
Merged
Conversation
This became unnecessary with #17877.
gziolo
approved these changes
Dec 2, 2019
Member
gziolo
left a comment
There was a problem hiding this comment.
I can't see the jump anymore. Looks good in my testing 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier today, I merged #18105. As part of that, two existing issues were visually surfaced. Technically the bugs were already present, but the issues were masked by the padding rules.
The issue existed in the first place because the appender component compensated for horizontal margins that were refactored away in #17877.
This affected groups and columns that had the placeholder appender.
Group, before:
Group, after:
Columns before:
Columns after: