Skip to content

Rnmobile/368 improve code block#18785

Merged
SergioEstevao merged 7 commits intomasterfrom
rnmobile/368_improve_code_block
Dec 2, 2019
Merged

Rnmobile/368 improve code block#18785
SergioEstevao merged 7 commits intomasterfrom
rnmobile/368_improve_code_block

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Nov 27, 2019

Description

Improves the presentation of the code block by:

  • Setting Menlo as the font
  • Correct the margins
  • Add a border around the code editor

How has this been tested?

This can be tested using the GB-Mobile PR:wordpress-mobile/gutenberg-mobile#1630

Screenshots

CodeDarkLight

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@SergioEstevao SergioEstevao added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 27, 2019
@SergioEstevao SergioEstevao added this to the Gutenberg 7.1 milestone Nov 27, 2019
@SergioEstevao SergioEstevao requested a review from koke November 27, 2019 15:44
@SergioEstevao SergioEstevao merged commit 69950b1 into master Dec 2, 2019
@SergioEstevao SergioEstevao deleted the rnmobile/368_improve_code_block branch December 2, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants