Fix: Styles that are wrapped with editor styles wrapper are not cached#18763
Closed
jorgefilipecosta wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closing this PR as the approach referred may have some problems in the core because the styles are concatenated there so isolating specific style sheets is not simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #18741
Description
Until now we passed the editor styles content via editor settings. The editor module transformed the CSS rules to wrap them and added them to a newly created style element on the page.
The current approach has two problems:
This PR proposes a different approach: Editor styles are enqueued to the client so they can be cached and the server does not need to download anything, as a setting we just pass the editor style URL's. On the client, we dynamically change the stylesheets to be correctly wrapped.
How has this been tested?
I checked the editor still looks as before.
Using the browser dev tools I checked the stylesheets were transformed as expected.