Skip to content

Navigation: fix adding CSS custom class issue#18629

Merged
retrofox merged 1 commit into
masterfrom
update/navigation-add-custom-css-class
Nov 20, 2019
Merged

Navigation: fix adding CSS custom class issue#18629
retrofox merged 1 commit into
masterfrom
update/navigation-add-custom-css-class

Conversation

@retrofox

@retrofox retrofox commented Nov 20, 2019

Copy link
Copy Markdown
Contributor

Description

It's a regression done by mistake. The original issue was taken over by @obenland (props!)

How has this been tested?

  • Create a navigation menu.

  • Set a custom color (from colors palette).
    image

  • Set a custom CSS class

Screen Shot 2019-11-20 at 9 17 11 AM

  • Save the post

Confirm that the HTML markup has both CSS classes:
Screen Shot 2019-11-20 at 9 17 57 AM

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.

It's a regression done by mistake. The original issue was taken over by @obenland (props!)
@retrofox retrofox added the [Block] Navigation Affects the Navigation Block label Nov 20, 2019
@retrofox retrofox requested a review from obenland November 20, 2019 15:38
@retrofox retrofox changed the title navigation: fix adding CSS custom class issue. Navigation: fix adding CSS custom class issue Nov 20, 2019

@obenland obenland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, :shipit:

@retrofox retrofox merged commit c79b5d9 into master Nov 20, 2019
@retrofox retrofox deleted the update/navigation-add-custom-css-class branch November 20, 2019 17:45
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Navigation Affects the Navigation Block

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants