Merged
Conversation
9588991 to
87b30e7
Compare
Escape lable and title when it comes from the blog posts
87b30e7 to
34200af
Compare
draganescu
approved these changes
Nov 22, 2019
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Tested locally and works great. Used the title <!--<Navigation Link/>±Scrip<*&!--> and the label is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue when the navigation links come from blog posts/pages. We need to escape special chars when the title and label are propagated to the RichText component.
Fixes #18613
How has this been tested?
<Navigation />:Before: Confirm that the link label is empty:
After
The link label should fill with the page title:
Types of changes
Checklist: